Versions Compared

Old Version 11

changes.mady.by.user Le Yao

Saved on

compared with

New Version 12

changes.mady.by.user Le Yao

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Gaps detection in source code

When testing the

...

QAT sriov support condition with the officer virtlet image, together with QAT device plugin. we take thie simple straightforward method that add the resource name qat.intel.com/generic advertised by the QAT device plugin to fileds spec.containers.resource.limits and spec.containers.resource.requests with value "1". It works correctly in plain kubernetes pods. But in a virtlet vm pod, we encountered the conflict caused by the configuration transformed between virtual machine and pod by virtlet. The issues is that when allocating a QAT vf device to virtlet vm pod, Kubelet will add the extended device to kubeapi.PodSandboxConfig.Devices (k8s.io/kubernetes/pkg/kubelet/apis/cri/runtime/v1alpha2 - v1.14). Then virtlet will incorrectly transforms all these devices to its volume devices and considers them as block disk with disk drivers bound to them later. 

    for _, dev := range in.Config.Devices {
        r.VolumeDevices = append(r.VolumeDevices, types.VMVolumeDevice{
            DevicePath: dev.ContainerPath,
            HostPath:   dev.HostPath,
        })
    }

It causes the errors that too many disks, disks' reading issues, denied permission and so on after a vm pod starts. And regardless of this, I want assign QAT vf to virtlet pod by pci-passthrough. So I want add corresponding fileds into libvirt instance domain xml created by virtlet. After code analysis, virtlet is a cri implentment and in its createDomain(config *types.VMConfig) *libvirtxml.Domain (pkg/libvirttools/virtualization.go) I detect the xml file creation and find it is using the libvirtxml "github.com/libvirt/libvirt-go-xml" go module. So the whole work flow is clear now and I can fix it then.

domain := &libvirtxml.Domain{
        Devices: &libvirtxml.DomainDeviceList{
            Emulator: "/vmwrapper",
            Inputs: []libvirtxml.DomainInput{
                {Type: "tablet", Bus: "usb"},
            },
            Graphics: []libvirtxml.DomainGraphic{
                {VNC: &libvirtxml.DomainGraphicVNC{Port: -1}},
            },
            Videos: []libvirtxml.DomainVideo{
                {Model: libvirtxml.DomainVideoModel{Type: "cirrus"}},
            },
            Controllers: []libvirtxml.DomainController{
                {Type: "scsi", Index: &scsiControllerIndex, Model: "virtio-scsi"},
            },
        },

...


Fix

continue

Example